Hi Erik On 29/10/2008, at 8:02 AM, Arjen Lentz wrote: > My main concern with this particular patch (great fast involvement > btw, thanks!) is that it introduces a dependency on sed.
Sorry amend that - just had a look at the current mysqld_safe and it already uses sed allover the place. So that's not a problem. Can the sed lines be done shorter/simpler? That'd be my only q there. And a # comment line above the sed foo explaining what it does and why. Then, yes please submit a branch with a new patch. Please my patch naming for bugfixes (in the BIG_TABLES patch). If you can make it such that it will apply both to the stock MySQL one as well as our already slightly modified one, we can use the patch as well as submit it upstream. Thanks! Cheers, Arjen. -- Arjen Lentz, Director @ Open Query (http://openquery.com.au) Training and Expertise for MySQL in Australia and New Zealand OurDelta: free enhanced builds for MySQL @ http://ourdelta.org -- mysqld_safe does not honour underscores in options like mysqld does https://bugs.launchpad.net/bugs/290190 You received this bug notification because you are a member of OurDelta- developers, which is the registrant for OurDelta. Status in OurDelta - Builds for MySQL: Confirmed Bug description: mysqld accepts both dashes and underscores in server options, however mysqld_safe does not. Since it's unclear from the user's perspective (and they shouldn't NEED to know!) which options get processed only by mysqld_safe, this can mean that they use an option in the wrong way but don't notice it. Example... open_files_limit When written like that, it mysqld_safe will not recognise it and thus not call ulimit -n ... The option WILL be feed to mysqld so it shows the "correct" number in SHOW GLOBAL VARIABLES. Except, since ulimit wasn't called, it's not actually in effect! See http://bugs.mysql.com/40368 _______________________________________________ Mailing list: https://launchpad.net/~ourdelta-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~ourdelta-developers More help : https://help.launchpad.net/ListHelp
