On Tue, Sep 29, 2009 at 05:12:58PM -0400, Mike Burns wrote:
> > + def get_dhcp_range_page(self, screen):
> > + self.__start_address = Entry(15,
> > self.__config.get_ipv4_start_address())
> > + self.__end_address = Entry(15,
> > self.__config.get_ipv4_end_address())
> > + grid = Grid(2,2)
> > + grid.setField(Label("Start:"), 0, 0, anchorRight = 1)
> > + grid.setField(self.__start_address, 1, 0, anchorLeft = 1)
> > + grid.setField(Label("End:"), 0, 1, anchorRight = 1)
> > + grid.setField(self.__end_address, 1, 1, anchorLeft = 1)
>
> If possible we might want to expand the size of these fields 1 char. If you
> have a
> max width IP address, the first char gets cut off from the display.
> Functionally,
> this is no impact, but it was confusing at first glance.
I don't see a way, from this side of the newt framework, to control the
size of the input window. Instead, we specify the max size of the data
entered (15 in the case) and newt decides on the size.
I'll put a personal backlog item up to go into newt-python and submit a
patch to them
> > + def get_network_type_page(self, screen):
> > + self.__isolated_network = Checkbox("Isolated virtual network",
> > +
> > self.__config.is_isolated_network())
> > + grid = Grid(1, 2)
> > + grid.setField(Label("Please indicate whether this virtual network
> > should be connected to the physical network."), 0, 0)
>
> On my vm, this label was too wide for the screen. I'm not sure if this
> is only my system, but we might want to split into multiple lines.
I've split this text into two separate labels show above the selection
list.
Pushing this after the changes are tested.
--
Darryl L. Pierce, Sr. Software Engineer @ Red Hat, Inc.
Virtual Machine Management - http://www.ovirt.org/
Is fearr Gaeilge bhriste ná Béarla cliste.
pgpkRVU9h9tS3.pgp
Description: PGP signature
_______________________________________________ Ovirt-devel mailing list [email protected] https://www.redhat.com/mailman/listinfo/ovirt-devel
