On 02/11/2010 11:35 AM, Mike Burns wrote:
On Thu, 2010-02-11 at 11:19 -0500, Joey Boggs wrote:
---
scripts/ovirt-config-storage | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/scripts/ovirt-config-storage b/scripts/ovirt-config-storage
index 9c3f773..10a4066 100755
--- a/scripts/ovirt-config-storage
+++ b/scripts/ovirt-config-storage
@@ -291,7 +291,7 @@ EOF
printf "Aborting"
return
elif [[ $mb_input =~ ^-*[0-9]+$ ]]; then
- if [[ $mb_input -ge $min_size || $mb_input =~ $part_regexp ]] \
+ if [[ $mb_input -ge $min_size || $mb_input =~ $part_regexp&&
$mb_input -ne 0 ]] \
&& [[ $mb_input -le $space_left ]] ; then
eval "$size_var=$mb_input"
size_used=$mb_input
If we're not supporting 0, we should also remove this:
diff --git a/scripts/ovirt-config-storage b/scripts/ovirt-config-storage
index be22ef6..1a50ea9 100755
--- a/scripts/ovirt-config-storage
+++ b/scripts/ovirt-config-storage
@@ -238,8 +238,7 @@ do_configure()
fi
printf "\n\nPlease configure storage partitions.\n\n"
printf "* Enter partition sizes in MB.\n"
- printf "* A value of 0 indicates the partition should be disabled.\n"
- printf "* If the partition is enabled, it will have a minimum
valid size.\n
+ printf "* All partitions have a minimum valid size.\n"
printf "* Size remaining value is approximate due to cylinder
rounding\n"
printf " during partitioning.\n"
printf "* For the Data partition, a size of -1 indicates that the\n"
I pulled this in from downstream, so I figured there would be some
discussion around this patch. Should there be support for 0MB sized
partitions? If not then I'll update the patch with the comments suggested.
_______________________________________________
Ovirt-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/ovirt-devel
