On Wed, May 26, 2010 at 09:23:44AM +0200, Andrew Beekhof wrote: > Some quick questions... > > Is the interval not being used yet? I don't see any timers or such.
Not implemented yet. This patch just introduces the actual heartbeat event over QMF. > Wouldn't you still need to update the network devices in Host::update()? Those are going to get refactored. As it stands they weren't being updated. > Does the heartbeat event need a counter (like ICMP packets do) to > detect backward jumps and/or lost heartbeats? Right now the heartbeat sends out the timestamp. But if the clock gets changed, it could seem to be a backwards jump. Changing it to be a counter instead would be a simple change to this patch for pushing. -- Darryl L. Pierce, Sr. Software Engineer @ Red Hat, Inc. Delivering value year after year. Red Hat ranks #1 in value among software vendors. http://www.redhat.com/promo/vendor/ _______________________________________________ Ovirt-devel mailing list [email protected] https://www.redhat.com/mailman/listinfo/ovirt-devel
