On Wed, 30 Sep 2026 15:52:01 -0400 Willem de Bruijn wrote: > If respinning, consider asking the LLM to rewrite commit messages to be > more concise.
Sure, will do in v5. > Not new with this series, nor high priority, so only if respinning: > > Consider adding > > @@ -5121,7 +5121,7 @@ struct sk_buff *skb_segment(struct sk_buff *head_skb, > } > > if (tail->len - doffset <= gso_size) > - skb_shinfo(tail)->gso_size = 0; > + skb_gso_reset(tail); > else if (tail != segs) > > Because packets looped into the Rx path will sometimes have their > gso_segs used without first checking gso_size / skb_is_gso. For instance > in ip_rcv_core __IP_ADD_STATS. Agreed. Several places count with gso_segs without checking gso_size (ip_rcv_core, tp->rcv_ooopack), and with this series the re-segmented output reaches them in-tree. I will add it as a new patch in the series. > Additionally for patch 5/5, consider one testcase that resegments, but for > which the last skb is not a GSO skb. Sure, will add in v5. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
