On 10/9/26 14:35, Mike Pattrick wrote:
On Fri, Oct 9, 2026 at 7:32 AM Kevin Traynor <[email protected]> wrote:
On 10/6/26 15:04, Timothy Redaelli wrote:
The 'filter' column of the Mirror table was parsed with
parse_ofp_exact_flow(), which requires every field that is mentioned to
be given as an exact value. Specifications like "ip,nw_src=10.0.0.0/24"
were therefore rejected, even though the matching side already stores the
filter as a miniflow plus minimask and unions that mask into the
megaflow, so partially masked fields work end to end.
Add parse_ofp_masked_flow(), which parses a flow specification into a
'struct flow' and 'struct flow_wildcards' and lets each value carry a
mask. Use it for the mirror filter. Like parse_ofp_exact_flow(), it
rejects fields whose prerequisites are not met, fields that are set
more than once and fields given without a value.
Both parsers now share a helper, parse_ofp_flow__(), driven by a 'masked'
flag: it parses each value with mf_parse() (masked) or mf_parse_value()
(exact) and applies it with the generic mf_set_flow_value[_masked]() /
mf_mask_field[_masked]() primitives. This keeps the exact path's
behaviour unchanged while adding masked support and avoiding duplicated
parsing logic. parse_ofp_exact_flow() is left in place, as its other
callers do want exact values.
We should simplify this as there's too a bit too much detail and
internal code references.
Reported-at: https://github.com/openvswitch/ovs-issues/issues/349
Reported-at: https://redhat.atlassian.net/browse/FDP-2474
Co-authored-by: Kevin Traynor <[email protected]>
Signed-off-by: Kevin Traynor <[email protected]>
Signed-off-by: Timothy Redaelli <[email protected]>
We should add:
Assisted-by: Claude Opus 4.8, Claude Code
Otherwise LGTM. (One minor comment below that doesn't require a code
change)
Let's give time in case there are other comments. If not, no need to
respin, I can take care of the commit message on apply. Thanks.
With Kevin's proposed changes,
Acked-by: Mike Pattrick <[email protected]>
Thanks Timothy and Mike. I updated the commit message and applied to
main branch.
Regards,
Kevin.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
