The Python library isn't dependent on the code in the OVS tree. It being in-tree has a few shortcomings. My rationale for recommending the split:
* Simple features and bugfixes for the Python lib can't be used by other projects (like Neutron) until the very latest OVS release is widely supported * Python 3 support is only available in version 2.6.0+ even though the code would work for previous releases * Implying that the Python lib and OVS versions are related when they aren't is confusing * A separate repo would allow adding committers that are familiar with the Python code, but less familiar with the C code. * As a Python-only project, it could be more easily tested, built, and packaged according to Python project best practices. The current build process requires the Python code, but this is easily remedied by using git submodules. People tend to reflexively dislike them, but they are perfect for this application. The OVS tree can lock to any particular commit for the new python-ovs repo and be guaranteed that changes don't break the ovs build. I made a fork to show how simple the change would be: https://github.com/otherwiseguy/ovs/commit/6766131b42807829ea78dbc43d164db8926030e7 commit 6766131b42807829ea78dbc43d164db8926030e7 Author: Terry Wilson <twil...@redhat.com> Date: Mon Nov 14 16:03:43 2016 -0600 Move python dir to a submodule diff --git a/.gitmodules b/.gitmodules new file mode 100644 index 0000000..db21481 --- /dev/null +++ b/.gitmodules @@ -0,0 +1,3 @@ +[submodule "python"] + path = python + url = https://github.com/otherwiseguy/python-ovs diff --git a/Makefile.am b/Makefile.am index a14d48b..2ce40ee 100644 --- a/Makefile.am +++ b/Makefile.am @@ -225,7 +225,7 @@ dist-hook-git: distfiles (cd datapath && $(MAKE) distfiles); \ (cat distfiles; sed 's|^|datapath/|' datapath/distfiles) | \ LC_ALL=C sort -u > all-distfiles; \ - (cd $(srcdir) && git ls-files) | grep -v '\.gitignore$$' | \ + (cd $(srcdir) && git ls-files) | grep -v 'python\|\.git\(ignore\|modules\)$$' | \ LC_ALL=C sort -u > all-gitfiles; \ LC_ALL=C comm -1 -3 all-distfiles all-gitfiles > missing-distfiles; \ if test -s missing-distfiles; then \ diff --git a/boot.sh b/boot.sh index 05dd359..d9a48fa 100755 --- a/boot.sh +++ b/boot.sh @@ -1,2 +1,3 @@ #! /bin/sh +[ -d .git ] && git submodule update --init --recursive autoreconf --install --force diff --git a/python b/python new file mode 160000 index 0000000..dd34813 --- /dev/null +++ b/python @@ -0,0 +1 @@ +Subproject commit dd348134a6e186725fe5aaa8d0a482fee0a88f2a ... < snip deleting python/ > Feel free to check it out and verify that it works. I split out the python directory here as a test https://github.com/otherwiseguy/python-ovs. As far as versioning, we could just pick a starting value of the new library of something like 3.0.0, breaking it out from the OVS versioning. Terry _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
