> From: "Ben Pfaff" <[email protected]> > To: "Lance Richardson" <[email protected]> > Cc: [email protected], [email protected] > Sent: Tuesday, November 22, 2016 6:05:33 PM > Subject: Re: [ovs-dev] [PATCH] rhel: fix ovn-common rpm installation failure > > On Mon, Nov 21, 2016 at 05:47:13PM -0500, Lance Richardson wrote: > > The directory /usr/lib/ocf/ does not exist if the pacemaker > > package has not been installed, which causes installation of the > > ovn-common rpm to fail on "mkdir /usr/lib/ocf/resource.d/ovn". > > Allow for the possibility that /usr/lib/ocf does not exist by > > using "mkdir -p". > > > > Fixes: a4245b7869c8 ("ovn: Add ovn db servers ocf script in fedora > > packager") > > Signed-off-by: Lance Richardson <[email protected]> > > --- > > rhel/openvswitch-fedora.spec.in | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/rhel/openvswitch-fedora.spec.in > > b/rhel/openvswitch-fedora.spec.in > > index d2cb3cd..d1f33af 100644 > > --- a/rhel/openvswitch-fedora.spec.in > > +++ b/rhel/openvswitch-fedora.spec.in > > @@ -311,7 +311,7 @@ rm -rf $RPM_BUILD_ROOT > > %endif > > > > %post ovn-common > > -mkdir /usr/lib/ocf/resource.d/ovn > > +mkdir -p /usr/lib/ocf/resource.d/ovn > > I'm a little surprised to see an empty directory getting created in a > script. I would have expected it to appear in the RPM file archive. At > least, that's how I'd do it in Debian packaging; I don't know RPMs very > well. >
Maybe someone more familiar with RPM packaging could comment. From my perspective, this was an improvement over having an RPM installation failure when the pacemaker package is not installed. I didn't question the existing implementation much but I did ask a couple of folks who are more familiar with RPM packaging whether this change seemed reasonable, and they thought it was. Thanks, Lance _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
