On Wed, Nov 23, 2016 at 1:25 AM, Babu Shanmugam <[email protected]> wrote:
> > > On Wednesday 23 November 2016 04:01 AM, Ben Pfaff wrote: > >> On Tue, Nov 15, 2016 at 05:27:22PM +0530, [email protected] wrote: >> >>> From: Babu Shanmugam <[email protected]> >>> >>> Openstack compute manager uses FQDN to check for the hypervisors to >>> which the ports are bound. >>> >>> Without this fix, no instances can be launched as the hypervisor's >>> hostname >>> mismatches. >>> >>> Signed-off-by: Babu Shanmugam <[email protected]> >>> >> Can you document in vswitch.xml that this is a fully qualified domain >> name, and that before OVS 2.7 it was not fully qualified? (Or, before >> 2.6.2, if you want it backported?) >> > > Sure, Ben I think it should be backported as well. > > > Also, there is some possibility that some installations relied on this >> being non-fully-qualified, and if we get bug reports about that change >> then we'd probably have to revert it. >> > > I understand. This current patch certainly makes things easier on the Neutron OVN driver, so with that hat on I like this change. :-) With my OVS maintainer hat on, I'm worried about breaking people, like Ben said. Since this was such a recent addition (new in 2.6), maybe nobody else is relying on it yet. We can hope for that! If anyone complains, we could just add a new external-id called "fqdn" or something, but that would also require changes to ovn-controller to expose that via the chassis record and some changes to the Neutron OVN driver to make use of the new field. -- Russell Bryant _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
