On Fri, Oct 14, 2016 at 04:35:46PM +0500, Valentine Sinitsyn wrote: > This is a quick attempt to implement sample action at logical port level.The > goal is to export IPFIX flows for logical ports, yet it is easy to extend > this approach to logical switches as well. > > Nothing is done to provision OVS instances with required > Flow_Sample_Collector_Set and IPFIX entries at this point. > > Does the approach I take looks sensible? If so, I can add tests and re-send > this patch for in-depth review. > > Many thanks. > > Signed-off-by: Valentine Sinitsyn <valentine.sinit...@gmail.com>
Sorry about the long delay in review. It's been a difficult month. This is pretty cool! The integration among OVS and OVN and IPFIX is graceful. The part that worries me is the CMS integration. Have you actually built that integration already (for which CMS)? I have two concerns. First, I'd prefer to see at least one CMS (probably OpenStack) support this at or around the time that it goes into OVN. Second, I have some skepticism around the idea that the CMS should configure the Flow_Sample_Collector_Set, etc., because OVN doesn't currently require the CMS to have any connectivity to OVSDB on each of the hypervisors and this would require the CMS to add that support. Do you have any thoughts about supporting other monitoring technology that OVS supports (e.g. sFlow) using similar techniques? I hope that the long delay does not discourage you from following up. I hope to be more responsive now. _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
