> > On 29.11.2016 15:20, Ilya Maximets wrote: > > If 'vhost-server-path' not provided for vhostuserclient port, > > 'netdev_dpdk_vhost_destruct()' will try to unregister an empty string. > > This leads to error message in log: > > > > netdev_dpdk|ERR|vhost2: Unable to unregister vhost driver for socket ''. > > > > CC: Ciara Loftus <[email protected]> > > Fixes: 2d24d165d6a5 ("netdev-dpdk: Add new 'dpdkvhostuserclient' port > type") > > Signed-off-by: Ilya Maximets <[email protected]> > > --- > > lib/netdev-dpdk.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c > > index b51f329..6e5cd43 100644 > > --- a/lib/netdev-dpdk.c > > +++ b/lib/netdev-dpdk.c > > @@ -1027,6 +1027,10 @@ netdev_dpdk_vhost_destruct(struct netdev > *netdev) > > ovs_mutex_unlock(&dev->mutex); > > ovs_mutex_unlock(&dpdk_mutex); > > > > + if (!strlen(dev->vhost_id)) { > > Sorry, > s/dev->vhost_id/vhost_id/
LGTM. Acked-by: Ciara Loftus <[email protected]> > > > + goto out; > > + } > > + > > if (dpdk_vhost_driver_unregister(dev, vhost_id)) { > > VLOG_ERR("%s: Unable to unregister vhost driver for socket > > '%s'.\n", > > netdev->name, vhost_id); > > @@ -1034,6 +1038,7 @@ netdev_dpdk_vhost_destruct(struct netdev > *netdev) > > /* OVS server mode - remove this socket from list for deletion */ > > fatal_signal_remove_file_to_unlink(vhost_id); > > } > > +out: > > free(vhost_id); > > } > > > > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
