On 28 November 2016 at 06:11, Alin Serdean <[email protected]> wrote: > This patch checks if the TCP or ICMP header exists before trying to use > them. > > The issue was found using the driver under low resources. > > Signed-off-by: Alin Gabriel Serdean <[email protected]>
(This is not a review, just a friendly reminder about patch ettiquette) Does this cause a kernel crash? Please use the imperative in git commit titles - It is easier to understand the evolution of the code in git logs when commits have clear titles like "Fix null dereference in conntrack". It is also helpful to include the potential impact of the change in the commit message (ie, kernel crash? memory leak? etc.). The "why" is more important in the commit message than the "what" - the "what" is already stated in the code. Linus wrote some good patch commit message guidelines here: https://github.com/torvalds/subsurface/blob/a48494d2fbed58c751e9b7e8fbff88582f9b2d02/README#L91 Thanks, Joe _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
