On Tue, Nov 01, 2016 at 02:39:29AM +0800, Hunt Xu wrote: > If a packet's vlan vid has been changed(striped or modified) before > entering the "normal" processing, it should be consider a packet on the > new VLAN. Therefore vlan checking is not needed. > > Signed-off-by: Hunt Xu <[email protected]>
I gave some general comments on this series in patch "0". To me, it seems brittle, nonorthogonal, and potentially surprising to change behavior for the remainder of the pipeline simply because an action pushes or pops a VLAN. > - bool action_set_has_group; /* Action set contains OFPACT_GROUP? */ > - struct ofpbuf action_set; /* Action set. */ > + bool action_set_has_group; /* Action set contains OFPACT_GROUP? */ > + bool action_set_changes_vlan_vid; /* Action set changes VLAN vid? */ > + struct ofpbuf action_set; /* Action set. */ I think that there's some kind of misunderstanding in naming here, since this feature doesn't have anything to do with the OpenFlow "action set" concept. Thanks, Ben. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
