On Mon, Dec 5, 2016 at 1:13 PM, Ben Pfaff <[email protected]> wrote:
> On Mon, Dec 05, 2016 at 10:10:43AM -0800, Ben Pfaff wrote:
> > On Mon, Dec 05, 2016 at 12:05:33PM -0500, Russell Bryant wrote:
> > > Document that the value of the ovn-remote configuration
> > > option must be an IP address. This came up on IRC where
> > > someone trying OVN put a hostname here and observed that
> > > it did not work.
> > >
> > > Signed-off-by: Russell Bryant <[email protected]>
> > > ---
> > > ovn/controller/ovn-controller.8.xml | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/ovn/controller/ovn-controller.8.xml b/ovn/controller/ovn-
> controller.8.xml
> > > index 5f51cb1..825a538 100644
> > > --- a/ovn/controller/ovn-controller.8.xml
> > > +++ b/ovn/controller/ovn-controller.8.xml
> > > @@ -93,7 +93,7 @@
> > > <dd>
> > > <p>
> > > The OVN database that this system should connect to for its
> > > - configuration.
> > > + configuration. The value must be an IP address.
> > > </p>
> >
> > Not an IP address but an OVSDB remote in the form tcp:ip[:port] or
> > ssl:ip[:port].
>
Ah yes. Thanks.
>
> Actually the documentation just below that paragraph is wrong too.
>
> Maybe something like this:
>
> diff --git a/ovn/controller/ovn-controller.8.xml b/ovn/controller/ovn-
> controller.8.xml
> index 5f51cb1..9f4dad1 100644
> --- a/ovn/controller/ovn-controller.8.xml
> +++ b/ovn/controller/ovn-controller.8.xml
> @@ -93,13 +93,8 @@
> <dd>
> <p>
> The OVN database that this system should connect to for its
> - configuration.
> - </p>
> -
> - <p>
> - Currently, <code>ovn-controller</code> does not support
> changing this
> - setting mid-run. If the value needs to change, the daemon must
> be
> - restarted. (This behavior should be improved.)
> + configuration, in one of the same forms documented above for the
> + <var>ovs-database</var>.
> </p>
> </dd>
>
>
I thought this option didn't take effect mid-run, but it's because there's
a stale comment left in the code.
I'll fix this up in v2.
diff --git a/ovn/controller/ovn-controller.c
b/ovn/controller/ovn-controller.c
index fea7841..4fbf455 100644
--- a/ovn/controller/ovn-controller.c
+++ b/ovn/controller/ovn-controller.c
@@ -204,10 +204,7 @@ get_chassis_id(const struct ovsdb_idl *ovs_idl)
}
/* Retrieves the OVN Southbound remote location from the
- * "external-ids:ovn-remote" key in 'ovs_idl' and returns a copy of it.
- *
- * XXX ovn-controller does not support this changing mid-run, but that
should
- * be addressed later. */
+ * "external-ids:ovn-remote" key in 'ovs_idl' and returns a copy of it. */
static char *
get_ovnsb_remote(struct ovsdb_idl *ovs_idl)
{
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
