On Sun, Dec 4, 2016 at 7:13 PM, Darrell Ball <[email protected]> wrote:
> This patch adds datapaths of interest support where only datapaths of > local interest are monitored by the ovn-controller ovsdb client. The > idea is to do a flood fill in ovn-controller of datapath associations > calculated by northd. A new column is added to the SB database > datapath_binding table - related_datapaths to facilitate this so all > datapaths associations are known quickly in ovn-controller. This > allows monitoring to adapt quickly with a single new monitor setting > for all datapaths of interest locally. > > We monitor both logical flows and logical ports. The mac bindings > will likely go away and multicast groups are relatively few. > To reduce risk and overall latency we only suppress logical flows as > a starting point. Logical ports are not suppressed as a starting > point and but then are monitor suppressed as appropriate from that > point on. The initial suppression has little practical gain and not > doing it allows for us to be flexible in terms of how different port > types are supported. > > To validate the gain, we take the approach to verify the l3gateway > router flow suppression from the non-l3gateway HVs POV and also add > a separate test to verify the flow and port handling scale advantages. > The separate test added verifies the logical port and logical flow > suppression advantage. This measures the difference in flows and ports > sent to the HV clients where the far majority of the overall work is. > The less ports and flows that are unnecessarily processed on the HVs, > the more benefit, excluding latency skew. The separate test is > simple for interpretation and shows an order of magnitude advantage; > the test uses only logical switches. The advantage would increase with > logical routers. The test is conservative in estimating the numerical > advantage to increase the probability of the check passing the first > time, since there are some timing conssiderations that affect the numbers. > > Liran Schour contributed enhancements to the conditional > monitoring granularity in ovs and also submitted patches > for ovn usage of conditional monitoring which aided this patch > though sharing of concepts through code review work. > > Ben Pfaff suggested that northd could be used to pre-populate > related datapaths for ovn-controller to use. That idea is > used as part of this patch. > > CC: Ben Pfaff <[email protected]> > CC: Liran Schour <[email protected]> > Signed-off-by: Darrell Ball <[email protected]> > --- > When I apply this patch to master, one of the tests is failing for me. This test passes if I drop the patch. 2296: ovn-controller - ovn-bridge-mappings FAILED ( ovn-controller.at:45) -- Russell Bryant _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
