On Mon, Dec 05, 2016 at 09:47:47PM +0100, Łukasz Rząsik wrote: > Adding / removing a range of integers to a column accepting a set of > integers requires enumarating all of the integers. This patch simplifies > it by introducing 'range' concept to the database commands. Two integers > separated by a hyphen represent an inclusive range. > > The patch adds positive and negative tests for the new syntax. > The patch was tested by 'make check'. Covarage was tested by > 'make check-lcov'. > > Signed-off-by: Lukasz Rzasik <[email protected]> > Suggested-by: <[email protected]> > Suggested-by: Ben Pfaff <[email protected]>
Thanks for contributing to Open vSwitch! This makes it easy for a user to explode OVS memory requirements. For example, if I just write "1-1000000000", it will use about 16 GB of memory in ovs-vsctl (maybe double or triple that!), transfer I guess about the same amount of data over the wire, and then write the same amount to disk at the database server. Do you have an idea of how to avoid that kind of problem? Please use 4-space indents consistently. I see some 2-space indents. Please use /* */ comments consistently. I see some // comments. Thanks, Ben. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
