On 12/12/2016 16:24, "Ben Pfaff" <[email protected]> wrote:
>On Mon, Dec 12, 2016 at 04:12:30PM -0800, Daniele Di Proietto wrote:
>> The order of the options in the packet generated by ovs-controller
>> depends on the hash function. I believe that murmur hash (our default)
>> produces different outputs depending on the endianness of the system.
>> Also, if SSE4.2 is enabled at build time, we use CRC32 for hashing which
>> gives different results even on x86.
>>
>> This causes one unit test to fail on big endian or with SSE4.2:
>>
>> ovn -- dhcpv4 : 1 HV, 2 LS, 2 LSPs/LS
>>
>> This commit fixes the problem in ovn-northd by always sorting dhcp
>> options inside the logical flow put_dhcp(v6)_opts action.
>>
>> Reported-at: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=840770
>> Suggested-by: Ben Pfaff <[email protected]>
>> Signed-off-by: Daniele Di Proietto <[email protected]>
>
>Thank you.
>
>Assuming the tests pass:
>Acked-by: Ben Pfaff <[email protected]>
Thanks for the review, I applied this to master and branch-2.6
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
