On Sun, Dec 18, 2016 at 12:18 AM, Ben Pfaff <b...@ovn.org> wrote:
> IDL tracking has a cost and nothing in ovn-controller was getting any value
> for that cost, so diable it.
>
s/diable/disable/
>
> Signed-off-by: Ben Pfaff <b...@ovn.org>
> ---
> ovn/controller/ovn-controller.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/ovn/controller/ovn-controller.c b/ovn/controller/ovn-
> controller.c
> index 4fbf455..8ba98bd 100644
> --- a/ovn/controller/ovn-controller.c
> +++ b/ovn/controller/ovn-controller.c
> @@ -463,8 +463,6 @@ main(int argc, char *argv[])
> ovsdb_idl_omit_alert(ovnsb_idl_loop.idl, &sbrec_chassis_col_nb_cfg);
>
> /* Track the southbound idl. */
> - ovsdb_idl_track_add_all(ovnsb_idl_loop.idl);
> -
>
Does the comment above still apply?
> ovsdb_idl_get_initial_snapshot(ovnsb_idl_loop.idl);
>
> /* Initialize connection tracking zones. */
> @@ -587,7 +585,6 @@ main(int argc, char *argv[])
> pinctrl_wait(&ctx);
> }
> ovsdb_idl_loop_commit_and_wait(&ovnsb_idl_loop);
> - ovsdb_idl_track_clear(ovnsb_idl_loop.idl);
>
> if (ovsdb_idl_loop_commit_and_wait(&ovs_idl_loop) == 1) {
> struct shash_node *iter, *iter_next;
> @@ -599,8 +596,6 @@ main(int argc, char *argv[])
> }
> }
> }
> - ovsdb_idl_track_clear(ovs_idl_loop.idl);
> -
> poll_block();
> if (should_service_stop()) {
> exiting = true;
> --
> 2.10.2
>
> Other than the small nits above,
Acked-by: Andy Zhou <az...@ovn.org>
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
