On Tue, Dec 20, 2016 at 03:18:43PM -0800, Joe Stringer wrote:
> On 20 December 2016 at 13:16, Ben Pfaff <b...@ovn.org> wrote:
> > A previous patch fixed double rebuilds when running tests in some cases.
> > That patch removed dependencies from targets in tests/automake.mk that
> > were redundant because the "all" target already depended on them. A
> > dependency on tests/atlocal was also removed in the belief that "all"
> > depended on tests/atlocal. This belief was incorrect, which meant that
> > tests/atlocal would not get regenerated if it was removed or out of date.
> > This commit fixes the problem.
> >
> > Reported-by: Joe Stringer <j...@ovn.org>
> > Fixes: a8cb456227b0 ("tests: Fix double-rebuild of testsuite for
> > "check-valgrind" and similar.")
> > Signed-off-by: Ben Pfaff <b...@ovn.org>
>
> Thanks for the fix! Seems to work fine, I'll let you know if I see any
> further trouble with it.
>
> Does tests/atconfig need the same attention?
>
> Acked-by: Joe Stringer <j...@ovn.org>
Thanks for the review. I applied this to master, adding your ack.
It's not clear to me whether tests/atconfig needs the same attention.
It depends on how tests/atlocal was causing a problem. What caused it
to need to be regenerated? Some possible reasons don't apply to
atconfig; for example, what appears in atconfig depends only on
decisions made during "configure", which is also what creates atconfig,
so there's never a reason to regenerate atconfig unless something
randomly deletes it, which shouldn't normally happen.
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
