Hi Darrell, Sorry for late response. I posted v3 just now.
On Wed, Dec 14, 2016 at 12:19 PM, Darrell Ball <[email protected]> wrote: > > ERROR log level is not appropriate since we always filter adding the extra flows anyways > > and it amount to extra processing and filtering. > > We anyways attempt to re-add every flow for every iteration of the ovn-controller main loop, > > not just physical flows; we filter these attempts with “installed_flows”, so we are doing lots > > of extra processing normally, at this time. > This is not true. There is a temporary flow_table constructed for desired flows, which is initiated and destructed in each iteration of main loop. The "duplicate flow" reported by the log is in fact for duplications in a single iteration. But I agree that ERROR log level is not necessary. > > > With the vtep test, the non-physical flows are not as many and diverse. So checking > > for attempting to add the same flow in the same iteration of ovn-controller main loop > > where the desired_flows log check is made (which is before the installed_flows check) > > should help to catch the physical flow duplicate attempts in a given iteration of the main loop. > > > > If we added the check there, we would be trying to catch some portion of the unnecessary extra > > processing and filtering which seems valid and avoid noisy logs, which could obscure other logs ? > > I added the check for the 3 HVs test case, which I think is more appropriate since it is basic functionality. Thanks, Han _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
