Regards
_Sugesh
....
> >> >> > + rx_csum_ol_flag = (dev->hw_ol_features &
> >> >> > +NETDEV_RX_CHECKSUM_OFFLOAD) != 0;
> >> >> > +
> >> >> > + if (rx_csum_ol_flag &&
> >> >> > + (info.rx_offload_capa & rx_chksm_offload_capa) !=
> >> >> > + rx_chksm_offload_capa) {
> >> >> > + VLOG_WARN_ONCE("Failed to enable Rx checksum offload on
> >> >> > + device
> >> >> %d",
> >> >> > + dev->port_id);
> This is not clear error msg. In this case device does not support requested
> offload feature. So the msg should mention that.
[Sugesh] Ok, Will change the error log message stating device doesn’t support
the feature.
>
> >> >> > + dev->hw_ol_features &= ~NETDEV_RX_CHECKSUM_OFFLOAD;
> >> >> > + return;
> >> >> > + }
> >> >> > + netdev_request_reconfigure(&dev->up);
> >> >> > +}
> >> >> > +
> >> >> I am not sure about need for netdev reconfigure here.
> >> > [Sugesh] Reconfigure is called here to enable/disable the checksum
> >> > at run time. Do you think the checksum will be updated on a user
> >> > request without having this call?
> >>
> >> I do not see need to reconfigure netdev here.
> > [Sugesh] Sorry Pravin, Looks like I am missing something here. Can you
> > please elaborate why you feel the reconfigure is not needed here?
>
> I thought we can enable rx checksum offload synchronously, but the device
> API does not allow it, so I agree we have to reconfigure netdev here.
[Sugesh] Ok
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
