On Mon, Jan 02, 2017 at 11:47:38AM +0000, Stephen Finucane wrote:
> Build documentation as part of every build. This ensures any syntax
> errors are caught early.
> 
> In addition, a 'check-docs' target is added to validates all external
> links.
> 
> The nitpick ('-n') flag is added to ensure all possible warnings are
> raised.
> 
> Signed-off-by: Stephen Finucane <step...@that.guru>
> Cc: Ben Pfaff <b...@ovn.org>
> ---
> v2:
> - Use 'htmldocs' target to validate docs, rather than 'check-docs'
> - Don't silence output of 'check-docs' target

Thanks.

I noticed that when the tree is configure with --enable-silent-rules,
the sphinx output is still pretty verbose.  I folded in the following to
silence it.  I didn't make a similar change for check-docs since that
one runs so slowly that feedback seems more or less mandatory.

--8<--------------------------cut here-------------------------->8--

diff --git a/Documentation/automake.mk b/Documentation/automake.mk
index cb41d11..6918066 100644
--- a/Documentation/automake.mk
+++ b/Documentation/automake.mk
@@ -98,9 +98,12 @@ PAPEROPT_a4 = -D latex_paper_size=a4
 PAPEROPT_letter = -D latex_paper_size=letter
 ALLSPHINXOPTS = -W -n -d $(SPHINXBUILDDIR)/doctrees $(PAPEROPT_$(PAPER)) 
$(SPHINXOPTS) $(SPHINXSRCDIR)
 
+sphinx_verbose = $(sphinx_verbose_@AM_V@)
+sphinx_verbose_ = $(sphinx_verbose_@AM_DEFAULT_V@)
+sphinx_verbose_0 = -q
 htmldocs:
        rm -rf $(SPHINXBUILDDIR)/*
-       $(SPHINXBUILD) -b html $(ALLSPHINXOPTS) $(SPHINXBUILDDIR)/html
+       $(AM_V_GEN)$(SPHINXBUILD) $(sphinx_verbose) -b html $(ALLSPHINXOPTS) 
$(SPHINXBUILDDIR)/html
 ALL_LOCAL += htmldocs
 .PHONY: htmldocs
 
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to