On 25 December 2016 at 03:39, Paul Blakey <[email protected]> wrote: > Add a new configuration option - hw-offload that enables netdev > flow api. Enabling this option will allow offloading flows > using netdev implementation instead of the kernel datapath. > This configuration option defaults to false - disabled. > > Signed-off-by: Paul Blakey <[email protected]> > Reviewed-by: Roi Dayan <[email protected]> > --- > lib/netdev.c | 18 ++++++++++++++++++ > lib/netdev.h | 2 ++ > vswitchd/bridge.c | 2 ++ > vswitchd/vswitch.xml | 11 +++++++++++ > 4 files changed, 33 insertions(+) > > diff --git a/lib/netdev.c b/lib/netdev.c > index 3ac3c48..b289166 100644 > --- a/lib/netdev.c > +++ b/lib/netdev.c > @@ -2071,7 +2071,25 @@ netdev_init_flow_api(struct netdev *netdev) > { > const struct netdev_class *class = netdev->netdev_class; > > + if (!netdev_flow_api_enabled) { > + return EOPNOTSUPP; > + } > + > return (class->init_flow_api > ? class->init_flow_api(netdev) > : EOPNOTSUPP); > } > + > +bool netdev_flow_api_enabled = false; > + > +void > +netdev_set_flow_api_enabled(bool enabled) > +{ > + static struct ovsthread_once once = OVSTHREAD_ONCE_INITIALIZER; > + > + if (ovsthread_once_start(&once)) { > + netdev_flow_api_enabled = enabled; > + VLOG_INFO("netdev: Flow API %s", enabled ? "Enabled" : "Disabled"); > + ovsthread_once_done(&once); > + } > +}
Requiring restart to apply this option seems a bit arbitrary, why not allow it to be changed at runtime? _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
