On 01/05/2017 12:23 AM, Daniele Di Proietto wrote: > 2017-01-04 7:31 GMT-08:00 Ciara Loftus <ciara.lof...@intel.com>: >> > 'dpdk' ports no longer have naming restrictions. Now, instead of >> > specifying the dpdk port ID as part of the name, the PCI address of the >> > device must be specified via the 'dpdk-devargs' option. eg. >> > >> > ovs-vsctl add-port br0 my-port >> > ovs-vsctl set Interface my-port type=dpdk >> > options:dpdk-devargs=0000:06:00.3 >> > >> > The user must no longer hotplug attach DPDK ports by issuing the >> > specific ovs-appctl netdev-dpdk/attach command. The hotplug is now >> > automatically invoked when a valid PCI address is set in the >> > dpdk-devargs. The format for ovs-appctl netdev-dpdk/detach command >> > has changed in that the user now must specify the relevant PCI address >> > as input instead of the port name. >> > >> > Signed-off-by: Ciara Loftus <ciara.lof...@intel.com> >> > Signed-off-by: Daniele Di Proietto <diproiet...@vmware.com> >> > Co-authored-by: Daniele Di Proietto <diproiet...@vmware.com> >> > Signed-off-by: Kevin Traynor <ktray...@redhat.com> >> > Co-authored-by: Kevin Traynor <ktray...@redhat.com> > Thanks for the new version > > I've been testing this for a while and I couldn't find any problems. > > The code looks good to me. > > I know that's a big change but at this point I think it's better to > merge it and refine (if we have to) it later. > > Kevin, do you have any more comments? >
no more comments - it's a nice usability improvement and I agree it is a good time to merge. _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev