This seems like it's an optimization rather than a correctness issue, but in general it's best to make "clone" like patch ports where there is no reason to depart from its design, since we know that patch ports work well.
Reported-by: Mickey Spiegel <mickeys....@gmail.com> Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2017-January/326981.html Fixes: 7ae62a676d3a ("ofp-actions: Add clone action.") Signed-off-by: Ben Pfaff <b...@ovn.org> --- ofproto/ofproto-dpif-xlate.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c index 6736c12..c6c17a4 100644 --- a/ofproto/ofproto-dpif-xlate.c +++ b/ofproto/ofproto-dpif-xlate.c @@ -4331,6 +4331,7 @@ xlate_sample_action(struct xlate_ctx *ctx, static void compose_clone_action(struct xlate_ctx *ctx, const struct ofpact_nest *oc) { + bool old_was_mpls = ctx->was_mpls; bool old_conntracked = ctx->conntracked; struct flow old_flow = ctx->xin->flow; @@ -4355,6 +4356,10 @@ compose_clone_action(struct xlate_ctx *ctx, const struct ofpact_nest *oc) /* The clone's conntrack execution should have no effect on the original * packet. */ ctx->conntracked = old_conntracked; + + /* Popping MPLS from the clone should have no effect on the original + * packet. */ + ctx->was_mpls = old_was_mpls; } static bool -- 2.10.2 _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
