On Thu, Jan 05, 2017 at 02:46:17AM -0800, Mickey Spiegel wrote:
> Currently in OVN, when a logical switch port of type "router" is
> created, the MAC and optionally IP addresses of the peer logical
> router port must be specified again as the addresses of the logical
> switch port.
> 
> This patch allows the logical switch port's addresses to be
> specified as the string "router", rather than explicitly copying the
> logical router port's MAC and optionally IP addresses.  The router
> addresses are used to populate the logical switch's destination
> lookup, and to populate op->lsp_addrs in ovn-northd.c, which in turn
> is used to generate logical switch ARP and ND replies.  Since ipam
> already looks at logical router ports, the only ipam modification
> necessary is to skip logical switch ports with addresses "router".
> 
> Signed-off-by: Mickey Spiegel <[email protected]>

I'd advise some documentation improvements, e.g.

diff --git a/ovn/ovn-nb.xml b/ovn/ovn-nb.xml
index f53fb9b..e52b29e 100644
--- a/ovn/ovn-nb.xml
+++ b/ovn/ovn-nb.xml
@@ -522,6 +522,7 @@
           <dt><code>router</code></dt>
           <dd>
             <p>
+              Accepted only when <ref column="type"/> is <code>router</code>.
               This indicates that the Ethernet, IPv4, and IPv6 addresses for
               this logical switch port should be obtained from the connected
               logical router port, as specified by <code>router-port</code> in
@@ -533,6 +534,11 @@
               switch's destination lookup, and also for the logical switch
               to generate ARP and ND replies.
             </p>
+
+            <p>
+              Supported only in OVN 2.7 and later.  Earlier versions required
+              router addresses to be manually synchronized.
+            </p>
           </dd>
 
         </dl>

Otherwise,
Acked-by: Ben Pfaff <[email protected]>
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to