2017-01-08 20:02 GMT-08:00 nickcooper-zhangtonghao <n...@opencloud.tech>: > Thanks Daniele, > Yes, it’s a small improvement. but it is necessary for us. I will check it > in > set_config(). One question to ask: should we check the tx/rx queue for > netdev-dpdk in set_config()?
I think for DPDK devices ultimately there's no way to check without actually setting up the queues, that's why it's done in reconfigure(). Thanks, Daniele > > Now we check it in dpdk_eth_dev_init(). > > Thanks. > > > > On Jan 9, 2017, at 11:22 AM, Daniele Di Proietto <diproiet...@ovn.org> > wrote: > > 2017-01-08 17:30 GMT-08:00 nickcooper-zhangtonghao <n...@opencloud.tech>: > > This patch avoids the ovs_rcu to report WARN, caused by blocked > for a long time, when ovs-vswitchd processes a port with many > rx/tx queues. The number of tx/rx queues per port may be appropriate, > because the dpdk uses it as an default max value. > > Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> > > > I don't think this is a big deal, since netdev-dummy is only used for > testing, but don't you think it's better to check it in set_config() > and return an error? > > Also, could you use the prefix netdev-dummy, instead of datapath? > > Thanks, > > Daniele > > _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev