User space implementation of the sample action is not consistent with
kernel datapath. In kernel datapath, the side effects of actions
within the sample actions are not visible to the subsequent actions.
Current user space handling does not follow the same logic. This patch
makes them consistent.
Signed-off-by: Andy Zhou <az...@ovn.org>
---
lib/odp-execute.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/lib/odp-execute.c b/lib/odp-execute.c
index 73e1016..cec7432 100644
--- a/lib/odp-execute.c
+++ b/lib/odp-execute.c
@@ -523,8 +523,16 @@ odp_execute_sample(void *dp, struct dp_packet *packet,
bool steal,
}
}
+ if (!steal) {
+ /* The 'subactions' may modify the packet, but the modification
+ * should not propagate beyond this sample action. Make a copy
+ * the packet in case we don't own the packet, so that the
+ * 'subactions' are only applid to the clone. 'odp_execute_actions'
+ * will free the clone. */
+ packet = dp_packet_clone(packet);
+ }
packet_batch_init_packet(&pb, packet);
- odp_execute_actions(dp, &pb, steal, nl_attr_get(subactions),
+ odp_execute_actions(dp, &pb, true, nl_attr_get(subactions),
nl_attr_get_size(subactions), dp_execute_action);
}
--
2.7.4
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
