On 11/01/2017 02:56, "Kevin Traynor" <[email protected]> wrote:
>On 01/07/2017 01:24 AM, Daniele Di Proietto wrote:
>> Since 55e075e65ef9("netdev-dpdk: Arbitrary 'dpdk' port naming"),
>> set_config() is used to identify a DPDK device, so it's better to report
>> its detailed error message to the user. Tunnel devices and patch ports
>> rely a lot on set_config() as well.
>>
>> This commit adds a param to set_config() that can be used to return
>> an error message and makes use of that in netdev-dpdk and netdev-vport.
>>
>> Before this patch:
>>
>> $ ovs-vsctl add-port br0 dpdk0 -- set Interface dpdk0 type=dpdk
>> ovs-vsctl: Error detected while setting up 'dpdk0': dpdk0: could not set
>> configuration (Invalid argument). See ovs-vswitchd log for details.
>> ovs-vsctl: The default log directory is "/var/log/openvswitch/".
>>
>> $ ovs-vsctl add-port br0 p+ -- set Interface p+ type=patch
>> ovs-vsctl: Error detected while setting up 'p+': p+: could not set
>> configuration (Invalid argument). See ovs-vswitchd log for details.
>> ovs-vsctl: The default log directory is "/var/log/openvswitch/".
>>
>> $ ovs-vsctl add-port br0 gnv0 -- set Interface gnv0 type=geneve
>> ovs-vsctl: Error detected while setting up 'gnv0': gnv0: could not set
>> configuration (Invalid argument). See ovs-vswitchd log for details.
>> ovs-vsctl: The default log directory is "/var/log/openvswitch/".
>>
>> After this patch:
>>
>> $ ovs-vsctl add-port br0 dpdk0 -- set Interface dpdk0 type=dpdk
>> ovs-vsctl: Error detected while setting up 'dpdk0': 'dpdk0' is missing
>> 'options:dpdk-devargs'. The old 'dpdk<port_id>' names are not supported.
>> See ovs-vswitchd log for details.
>> ovs-vsctl: The default log directory is "/var/log/openvswitch/".
>>
>> $ ovs-vsctl add-port br0 p+ -- set Interface p+ type=patch
>> ovs-vsctl: Error detected while setting up 'p+': p+: patch type requires
>> valid 'peer' argument. See ovs-vswitchd log for details.
>> ovs-vsctl: The default log directory is "/var/log/openvswitch/".
>>
>> $ ovs-vsctl add-port br0 gnv0 -- set Interface gnv0 type=geneve
>> ovs-vsctl: Error detected while setting up 'gnv0': gnv0: geneve type
>> requires valid 'remote_ip' argument. See ovs-vswitchd log for details.
>> ovs-vsctl: The default log directory is "/var/log/openvswitch/".
>>
>> CC: Ciara Loftus <[email protected]>
>> CC: Kevin Traynor <[email protected]>
>> Signed-off-by: Daniele Di Proietto <[email protected]>
>> ---
>> lib/netdev-dpdk.c | 27 ++++++++++--------
>> lib/netdev-dummy.c | 3 +-
>> lib/netdev-provider.h | 9 ++++--
>> lib/netdev-vport.c | 76
>> ++++++++++++++++++++++++++++++++++-----------------
>> lib/netdev.c | 10 +++++--
>> 5 files changed, 84 insertions(+), 41 deletions(-)
>>
>
>Note the commit message lines get truncated in git log, you may want to
>wrap them. It's much more intuitive now, thanks.
>
>Acked-by: Kevin Traynor <[email protected]>
I'm always unsure what to do with long commit messages, especially with
shell commands or gdb stack traces.
Documentation/internals/contributing/submitting-patches.rst explicitly
suggests to limit lines to 75 characters, so I have to agree with you :-)
Pushed to master, thanks
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
