On Sat, Jan 14, 2017 at 07:37:53PM +0530, Numan Siddique wrote: > On Sat, Jan 14, 2017 at 3:18 AM, Ben Pfaff <[email protected]> wrote: > > > On Tue, Jan 10, 2017 at 11:34:42AM +0530, Numan Siddique wrote: > > > ovn-controller by default enables UDP checksums for geneve > > > tunnels. With this patch user can set the desired value in > > > Open_vSwitch.external_ids:ovn_encap_csum. > > > > > > Signed-off-by: Numan Siddique <[email protected]> > > > > I don't see technical problems with this, but I also don't know why a > > user would want to disable checksums. Can you send a v2 that adds this > > rationale to the documentation and to the commit message? > > > > Thanks for the review. Sure I will do that. The reason for this patch is - > we are seeing significant performance increase (more than 100%) in our > testing when tunnel checksum is disabled. > > The lab servers have nics with geneve offload support ( > tx-udp_tnl-segmentation > ) > .
OK, that sounds like a good reason to document. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
