On Fri, Jan 13, 2017 at 02:04:38PM -0800, Shu Shen wrote: > The return type of vlan_tci_to_pcp() was int where it's expected to be > uint8_t and causing implicit truncation when the function is used. On > some platforms such as macOS, where PRIu8 is defined as "hhx" and no > promotion of short to int is done, the compiler might throw out Wformat > message for ds_put_format() calls on the returns value of > vlan_tci_to_pcp(). > > vlan_tci_to_cfi() is also fixed with uint8_t as return type although the > function is not currently being used anywhere. > > Format strings in ds_put_format() for printing out returned values from > vlan_tci_to_pcp() were updated to ensure PRIu8 or PRIx8 are used for > portability. > > Signed-off-by: Shu Shen <[email protected]> > --- > > v2: Fixed typoes for uint8_t in commit message
This one doesn't really make sense to me. This patch only changes two format specifiers away from %d or %x, which are both correct format specifiers for "int". Can you explain? Thanks, Ben. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
