Patch 2 and 3 could’ve been combined into the same patch since they are about dst_port.
Acked-by: Sairam Venugopal <[email protected]> On 1/10/17, 8:48 AM, "[email protected] on behalf of Alin Serdean" <[email protected] on behalf of [email protected]> wrote: >'OvsTunnelAttrToIPv4TunnelKey' modifies 'tunkey' with the received netlink >attributes(i.e. OVS_TUNNEL_KEY_ATTR_IPV4_DST). > >Change the order of the value assignment to reflect the values received via >userspace. > >Signed-off-by: Alin Gabriel Serdean <[email protected]> >--- > datapath-windows/ovsext/Actions.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/datapath-windows/ovsext/Actions.c >b/datapath-windows/ovsext/Actions.c >index b4a286b..1530d8b 100644 >--- a/datapath-windows/ovsext/Actions.c >+++ b/datapath-windows/ovsext/Actions.c >@@ -1492,11 +1492,11 @@ OvsExecuteSetAction(OvsForwardingContext *ovsFwdCtx, > case OVS_KEY_ATTR_TUNNEL: > { > OvsIPv4TunnelKey tunKey; >+ tunKey.flow_hash = (uint16)(hash ? *hash : OvsHashFlow(key)); >+ tunKey.dst_port = key->ipKey.l4.tpDst; > NTSTATUS convertStatus = OvsTunnelAttrToIPv4TunnelKey((PNL_ATTR)a, > &tunKey); > status = SUCCEEDED(convertStatus) ? NDIS_STATUS_SUCCESS : > NDIS_STATUS_FAILURE; > ASSERT(status == NDIS_STATUS_SUCCESS); >- tunKey.flow_hash = (uint16)(hash ? *hash : OvsHashFlow(key)); >- tunKey.dst_port = key->ipKey.l4.tpDst; > RtlCopyMemory(&ovsFwdCtx->tunKey, &tunKey, sizeof ovsFwdCtx->tunKey); > break; > } >-- >2.10.2.windows.1 >_______________________________________________ >dev mailing list >[email protected] >https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.openvswitch.org_mailman_listinfo_ovs-2Ddev&d=DwICAg&c=uilaK90D4TOVoH58JNXRgQ&r=Z6vowHUOjP5ysP_g372c49Nqc1vEKqHKNBkR5Q5Z7uo&m=ZijUW-XONuy4-0Gaus241SbH5Y3jgJ6h3MNUavcwlRc&s=1XFYfOzat_zlBGT85Z2Z7b3sEH8rtGJQKCGCjXsLtag&e= > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
