On Fri, Jan 20, 2017 at 9:16 AM, Ben Pfaff <[email protected]> wrote:
> I believe that, with these patches, egress loopback as proposed by Mickey's
> patches can be implemented with:
> clone { inport = outport; outport = ""; flags.loopback = 0;
> reg0 = 0; reg1 = 0; ... regN = 0;
> next(pipeline=ingress, table=0); }
>
My main concern is maintainability as new flags or registers are added.
Having one line of code buried deep inside ovn/northd/ovn-northd.c that
needs to be updated whenever a flag or register is added worries me.
Does it make sense to add "clear_regs" and "clear_flags" actions in
order to address that concern?
I would also need to add in_port to symtab in ovn/lib/logical-fields.c so
that I can clear it.
> Ben Pfaff (10):
> actions: Fix "arp" and "nd_na" followed by another action.
> lex: Make lexer_force_match() work for LEX_T_END.
> actions: Make "arp { drop; };" acceptable.
> actions: Make "free" functions per-struct, not per-action.
> actions: Add new OVN action "clone".
> actions: Separate action structures for "next" and "ct_next".
> actions: Omit table number when possible for formatting "next" action.
> actions: Introduce enum ovnact_pipeline.
> actions: Make "next" action able to jump from egress to ingress
> pipeline.
> actions: Add new "ct_clear" action.
>
For patches 1 through 4, 6, and 8:
Acked-by: Mickey Spiegel <[email protected]>
I commented separately on patches 5 and 7.
I could not apply patches 9 and 10 since I manually fixed patch 7
and the indexes did not match.
Mickey
> include/ovn/actions.h | 91 ++++++++++-----
> include/ovn/lex.h | 4 +-
> ovn/controller/lflow.c | 7 +-
> ovn/lib/actions.c | 284 +++++++++++++++++++++++++++---
> ----------------
> ovn/lib/lex.c | 13 ++-
> ovn/ovn-sb.xml | 26 ++++-
> ovn/utilities/ovn-trace.c | 65 +++++++----
> tests/ovn.at | 45 +++++++-
> tests/test-ovn.c | 6 +-
> 9 files changed, 352 insertions(+), 189 deletions(-)
>
> --
> 2.10.2
>
> _______________________________________________
> dev mailing list
> [email protected]
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
