> On Dec 28, 2016, at 1:10 PM, Ben Pfaff <[email protected]> wrote: > > From: Ben Pfaff <[email protected]> > > There is still plenty of opportunity for improvement, but this new > ovs-fields(7) manpage is much more comprehensive than ovs-ofctl(8) > could be. > > Signed-off-by: Ben Pfaff <[email protected]> > --- > Documentation/ref/index.rst | 4 + > build-aux/extract-ofp-fields | 359 +++- > include/openvswitch/meta-flow.h | 205 +- > lib/automake.mk | 17 +- > lib/meta-flow.xml | 4163 +++++++++++++++++++++++++++++++++++++++ > ovn/ovn-architecture.7.xml | 2 +- > ovn/utilities/ovn-trace.8.xml | 2 +- > python/build/nroff.py | 62 +- > utilities/ovs-ofctl.8.in | 993 +--------- > vswitchd/vswitch.xml | 6 +- > 10 files changed, 4573 insertions(+), 1240 deletions(-) > create mode 100644 lib/meta-flow.xml
Since the documentation formatted well, I'm going to assume extract-ofp-fields and nroff.py are written perfectly and without error. > diff --git a/lib/meta-flow.xml b/lib/meta-flow.xml > new file mode 100644 > index 0000000..1b646f5 > --- /dev/null > +++ b/lib/meta-flow.xml For everyone else's benefit, I printed out the ovs-fields man page and directly marked the page with feedback, which I handed to Ben. I'm sure he'd be happy to scan all 57 pages for anyone interested. > diff --git a/utilities/ovs-ofctl.8.in b/utilities/ovs-ofctl.8.in > index af1eb2b..a3a29b1 100644 > --- a/utilities/ovs-ofctl.8.in > +++ b/utilities/ovs-ofctl.8.in > > ... > +\fBovs\-fields\fR(7) describes the supported fields and how to match > +them. In addition to match fields, commands that operate on flow > +accept a few addition key-value pairs: s/flow/flows s/addition/additional > +.IP "\fBduration=\fR..." > +.IQ "\fBn_packet=\fR..." > +.IQ "\fBn_bytes=\fR..." > +These ``fields'' are ignored to allow output from the \fBdump\-flows\fR > command to be used as input for other commands that parse flows. I actually found the previous way this was written clearer. This was a lot of work. Thanks for doing it! --Justin _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
