Answer inline. Thanks, Alin.
> -----Original Message----- > From: Sairam Venugopal [mailto:[email protected]] > Sent: Friday, January 27, 2017 2:36 AM > To: Alin Serdean <[email protected]>; > [email protected] > Subject: Re: [ovs-dev] [PATCH] windows: wmi add include > > Hi Alin, > > Does this fix the access violation error in wcscat_s inside create_wmi_port()? > I ran into this issue when creating a bridge previously. [Alin Serdean] It shouldn't fix it. I found it when a wmi error ocurred and 'get_hres_error' was called. If you can provide a stacktrace or dump I would be happy to investigate. > > I will apply this patch and re-test. > > Thanks, > Sairam > > > > On 1/26/17, 2:15 PM, "[email protected] on behalf of Alin > Serdean" <[email protected] on behalf of > [email protected]> wrote: > > >Add 'util.h' to includes otherwise the definition of the function > >ovs_format_message will be unknown and an abort with the following > stacktrace will be triggered: > >*1 ovs-vswitchd.exe!_output_l(_iobuf * stream=0x000000bb711dcbf0, > const char * format=0x00007ff6016a2c12, localeinfo_struct * plocinfo, char * > argptr=0x00007ff60176b460) > > 2 ovs-vswitchd.exe!_vscprintf_helper(int (_iobuf *, const char *, > localeinfo_struct *, char *) * outfn=0x00007ff60160d4d0, const char * > format=0x00007ff6016a2c10, localeinfo_struct * > plocinfo=0x0000000000000000, char * ap=0x000000bb711dce98) > > 3 ovs-vswitchd.exe!ovs_vsnprintf(char * s=0x00000000000003de, > unsigned __int64 n=140694562417680, const char * > format=0x000000bb711dce98, char * args=0x000000bb711dcdf8) > > 4 ovs-vswitchd.exe!ds_put_format_valist(ds * ds=0x000000bb711dce98, > const char * format=0x00007ff6016ba1de, char * args_=0x00007ff6016a2c10) > > 5 ovs-vswitchd.exe!format_log_message(const vlog_module * > module=0x000002933ce9a560, vlog_level level=VLL_OFF, const char * > pattern=0x0000000000000000, const char * message=0x0000000000000000, > char * args_=0x000000bb711dce98, ds * s=0x000000bb711dcdf8) > > 6 ovs-vswitchd.exe!vlog_valist(const vlog_module * > module=0x000002930000000b, vlog_level level=VLL_OFF, const char * > message=0x0000000080041001, char * args=0x000000bb711dcf80) > > 7 ovs-vswitchd.exe!vlog(const vlog_module * > module=0x0000000080041001, vlog_level level=1022648016, const char * > message=0x00007ff6016a2c10, ...) > > 8 ovs-vswitchd.exe!create_wmi_port(char * > name=0x0000000000000000) > > 9 ovs-vswitchd.exe!dpif_netlink_port_add__(dpif_netlink * > dpif=0x000002933cea6840, netdev * netdev=0x0000000000000000, unsigned > int * port_nop=0x0000000000000000) > > 10 ovs-vswitchd.exe!dpif_netlink_port_add(dpif * > dpif_=0x000000bb711df360, netdev * netdev=0x000002933cea05c0, > unsigned int * port_nop=0x000002933cefcdf0) > > 11 ovs-vswitchd.exe!dpif_port_add(dpif * dpif=0x000002933cf3ecc0, > netdev * netdev=0x000002933cf0a5b0, unsigned int * > port_nop=0x000002933cf0a5b0) > > 12 ovs-vswitchd.exe!port_add(ofproto * ofproto_=0x000002933cefcdf0, > netdev * netdev=0x0000000000000000) > > 13 ovs-vswitchd.exe!ofproto_port_add(ofproto * > ofproto=0x0000000000000000, netdev * netdev=0x000002933cf3e690, > unsigned int * ofp_portp=0x000000bb711df5c8) > > 14 ovs-vswitchd.exe!iface_do_create(const bridge * > br=0x000002933cf097e0, const ovsrec_interface * > iface_cfg=0x000002933cefcdf0, unsigned int * > ofp_portp=0x000002933cf3d400, netdev * * netdevp=0x000002933cee2cb0, > char * * errp=0x000000bb711df570) > > 15 ovs-vswitchd.exe!iface_create(bridge * br=0x000002933cf097e0, > const ovsrec_interface * iface_cfg=0x000000000000ffff, const ovsrec_port * > port_cfg=0x000002933cea35d0) > > 16 ovs-vswitchd.exe!bridge_add_ports__(bridge * > br=0x0000000000000000, const shash * wanted_ports=0x000002933cee2cb0, > bool with_requested_port=232) > > 17 ovs-vswitchd.exe!bridge_reconfigure(const ovsrec_open_vswitch * > ovs_cfg=0x000002933cee2cb0) > > 18 ovs-vswitchd.exe!bridge_run() > > 19 ovs-vswitchd.exe!main(int argc=1, char * * argv=0x000002933ce78f60) > > 20 ovs-vswitchd.exe!__tmainCRTStartup() > > 21 kernel32.dll!BaseThreadInitThunk?() > > 22 ntdll.dll!RtlUserThreadStart?() > > > >Signed-off-by: Alin Gabriel Serdean <[email protected]> > >--- > >Intended for master and branch-2.7 > >--- > > lib/wmi.c | 1 + > > 1 file changed, 1 insertion(+) > > > >diff --git a/lib/wmi.c b/lib/wmi.c > >index e38b482..2203df4 100644 > >--- a/lib/wmi.c > >+++ b/lib/wmi.c > >@@ -20,6 +20,7 @@ > > #include <stdio.h> > > #include <tchar.h> > > #include "openvswitch/vlog.h" > >+#include "util.h" > > > > VLOG_DEFINE_THIS_MODULE(wmi); > > > >-- > >2.10.2.windows.1 > >_______________________________________________ > >dev mailing list > >[email protected] > >https://urldefense.proofpoint.com/v2/url?u=https- > 3A__mail.openvswitch.o > >rg_mailman_listinfo_ovs- > 2Ddev&d=DwICAg&c=uilaK90D4TOVoH58JNXRgQ&r=Z6vow > >HUOjP5ysP_g372c49Nqc1vEKqHKNBkR5Q5Z7uo&m=zHgfkeMCv9XxPuogGV > P_X3q9b78agM > >WmGCFjb5IBfFk&s=iPXS4cVczuoSy6YeOLEcTOob6Kpxnu- > vC4bA6zjw3ns&e= _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
