On Thu, Feb 02, 2017 at 10:40:31AM -0500, Russell Bryant wrote:
> On Thu, Feb 2, 2017 at 10:32 AM, Numan Siddique <nusid...@redhat.com> wrote:
> 
> > On Wed, Feb 1, 2017 at 4:31 AM, Ben Pfaff <b...@ovn.org> wrote:
> >
> > > On Sun, Jan 15, 2017 at 12:36:09PM +0530, Numan Siddique wrote:
> > > > ovn-controller by default enables tunnel encapsulation checksums
> > > > for geneve tunnels. With this patch user can set the desired value
> > > > in Open_vSwitch.external_ids:ovn_encap_csum.
> > > >
> > > > This option will be useful in cases where enabling tunnel
> > > > encapsulation checksums incur significant performance loss due to
> > > > limitations in checksum offloading capabilities of the nics.
> > > >
> > > > Signed-off-by: Numan Siddique <nusid...@redhat.com>
> > >
> > > Thanks.  I applied this to master.
> > >
> >
> > ​Thanks Ben for the review and applying it. Can this be applied to branch
> > 2.7 as well ?
> >
> 
> I'm supportive of backporting it.
> 
> Just to elaborate on why we care ...
> 
> With checksums enabled, we are not able to make use of the
> tx-udp_tnl-segmentation offload.  We will be able to leave checksums
> enabled once we also have support for tx-udp_tnl-csum-segmentation, which
> is present in the upstream kernel but not the RHEL kernel yet.  So, right
> now to get the best overall performance, we have to disable checksums (for
> current CentOS / RHEL, anyway).

OK, I applied to branch-2.7 too.
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to