On 18 January 2017 at 11:45, Eric Garver <[email protected]> wrote:
> Creates VXLAN devices using rtnetlink and tunnel metadata.
>
> Co-Authored-by: Thadeu Lima de Souza Cascardo <[email protected]>
> Co-Authored-by: Eric Garver <[email protected]>
> Signed-off-by: Eric Garver <[email protected]>
> ---
> lib/dpif-netlink.c | 194
> ++++++++++++++++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 193 insertions(+), 1 deletion(-)
I think that the vast majority of this code is linux-specific and
should not exist in dpif-netlink.c.
Perhaps we should add a new lib/netdev-lwt.[ch], where the .h file has
the #ifdef __linux__ logic to either declare or define the functions,
then lib/netdev-lwt.c has the implementations of these functions. The
.h would always be added to the build in lib/automake.mk and the .c
file would only be added in the #if LINUX section.
One might even argue that it'd be tidier if the
dpif_netlink_port_{create,destroy} functions were moved here (and
renamed to something more apt).
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
