Recently, write a script add and delete port repeatly, ovs upcall handler
thread crash with the following trace.
In the code bellow, weather the operations of mbridge->mbundles hmap should
with a lock to protect content between ovs-vswichd thread and the upcall
handler thread:
static struct mbundle *
mbundle_lookup(const struct mbridge *mbridge, struct ofbundle *ofbundle)
{
struct mbundle *mbundle;
HMAP_FOR_EACH_IN_BUCKET (mbundle, hmap_node, hash_pointer(ofbundle, 0),
&mbridge->mbundles) {
if (mbundle->ofbundle == ofbundle) {
return mbundle;
}
}
return NULL;
}
Call Trace:
#0 0x000000000044d838 in mbundle_lookup (mbridge=0x7fbf68000cc0,
ofbundle=0x7fbf7007c3d0) at ofproto/ofproto_dpif_mirror.c:472
#1 0x000000000044da15 in mirror_bundle_out (mbridge=<optimized out>,
ofbundle=<optimized out>) at ofproto/ofproto_dpif_mirror.c:192
#2 0x0000000000448658 in xbundle_mirror_out (xbridge=0x7fbf5c6468a0,
xbundle=0x7fbf3d48a160) at ofproto/ofproto_dpif_xlate.c:1556
#3 xlate_normal_flood (ctx=ctx@entry=0x7fbf7729e3d0,
in_xbundle=in_xbundle@entry=0x7fbf5c22f870, vlan=vlan@entry=100) at
ofproto/ofproto_dpif_xlate.c:2525
#4 0x0000000000448e7e in xlate_normal (ctx=0x7fbf7729e3d0) at
ofproto/ofproto_dpif_xlate.c:2724
#5 xlate_output_action (ctx=ctx@entry=0x7fbf7729e3d0, port=<optimized out>,
max_len=<optimized out>, may_packet_in=may_packet_in@entry=true) at
ofproto/ofproto_dpif_xlate.c:4061
#6 0x0000000000445147 in do_xlate_actions (ofpacts=0x6eb7288, ofpacts_len=16,
ctx=ctx@entry=0x7fbf7729e3d0) at ofproto/ofproto_dpif_xlate.c:4616
#7 0x0000000000446481 in xlate_recursively (rule=0x6eb7100, ctx=0x7fbf7729e3d0)
at ofproto/ofproto_dpif_xlate.c:3445
#8 xlate_table_action (ctx=0x7fbf7729e3d0, in_port=<optimized out>,
table_id=<optimized out>, may_packet_in=<optimized out>,
honor_table_miss=<optimized out>) at ofproto/ofproto_dpif_xlate.c:3513
#9 0x00000000004475a2 in compose_output_action__ (ctx=ctx@entry=0x7fbf7729e3d0,
ofp_port=<optimized out>, xr=<optimized out>, check_stp=check_stp@entry=true)
at ofproto/ofproto_dpif_xlate.c:3206
#10 0x0000000000447bbf in compose_output_action (xr=<optimized out>,
ofp_port=<optimized out>, ctx=0x7fbf7729e3d0) at
ofproto/ofproto_dpif_xlate.c:3426
#11 output_normal (ctx=ctx@entry=0x7fbf7729e3d0,
out_xbundle=out_xbundle@entry=0x7fbf5cdf4aa0, vlan=vlan@entry=0) at
ofproto/ofproto_dpif_xlate.c:2073
#12 0x00000000004486ae in xlate_normal_flood (ctx=ctx@entry=0x7fbf7729e3d0,
in_xbundle=in_xbundle@entry=0x7fbf5e1d44d0, vlan=vlan@entry=0) at
ofproto/ofproto_dpif_xlate.c:2529
#13 0x0000000000448e7e in xlate_normal (ctx=0x7fbf7729e3d0) at
ofproto/ofproto_dpif_xlate.c:2724
#14 xlate_output_action (ctx=ctx@entry=0x7fbf7729e3d0, port=<optimized out>,
max_len=<optimized out>, may_packet_in=may_packet_in@entry=true) at
ofproto/ofproto_dpif_xlate.c:4061
#15 0x0000000000445147 in do_xlate_actions
(ofpacts=ofpacts@entry=0x7fbf70005ae8, ofpacts_len=ofpacts_len@entry=8,
ctx=ctx@entry=0x7fbf7729e3d0) at ofproto/ofproto_dpif_xlate.c:4616
#16 0x000000000044a739 in xlate_actions (xin=xin@entry=0x7fbf7729f570,
xout=xout@entry=0x7fbf772c0b18) at ofproto/ofproto_dpif_xlate.c:5509
#17 0x000000000043e4b6 in upcall_xlate (wc=0x7fbf772c0b70,
odp_actions=0x7fbf772c0b30, upcall=0x7fbf772c0ac0, udpif=0x6e164a0) at
ofproto/ofproto_dpif_upcall.c:1082
#18 process_upcall (udpif=udpif@entry=0x6e164a0,
upcall=upcall@entry=0x7fbf772c0ac0,
odp_actions=odp_actions@entry=0x7fbf772c0b30, wc=wc@entry=0x7fbf772c0b70) at
ofproto/ofproto_dpif_upcall.c:1220
#19 0x00000000004407d3 in recv_upcalls (handler=0x7fbf58944810,
handler=0x7fbf58944810) at ofproto/ofproto_dpif_upcall.c:784
#20 0x0000000000440cca in udpif_upcall_handler (arg=0x7fbf58944810) at
ofproto/ofproto_dpif_upcall.c:701
#21 0x00000000004c95e4 in ovsthread_wrapper (aux_=<optimized out>) at
lib/ovs_thread.c:649
#22 0x00007fbf7aeaedc5 in start_thread () from /usr/lib64/libpthread.so.0
#23 0x00007fbf79a5e71d in clone () from /usr/lib64/libc.so.6
#0 0x000000000044d838 in mbundle_lookup (mbridge=0x7fbf68000cc0,
ofbundle=0x7fbf7007c3d0)
472 if (mbundle->ofbundle == ofbundle) {
(gdb) p mbundle
$1 = (struct mbundle *) 0x31
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
