Hi Alin, I don't see a big value from this patch if I understand it correctly. Firstly, your commit is not clear about what it means when it says "typing it later on". Are you referring to typing it later on in the documentation? Secondly, since Hyper-V has different switch types such as "internal", "external", "private", replacing the switch name in the documentation with "external" might confuse readers unnecessarily, since its also a type. If you want to rename it, you could just call it something like "ovsext-switch" or just "ovsext".
Please find the other comments inline. Thanks, Shashank ________________________________ From: [email protected] <[email protected]> on behalf of Alin Serdean <[email protected]> Sent: Saturday, February 4, 2017 12:21 AM To: [email protected] Subject: [ovs-dev] [PATCH 4/4] doc-windows: Consolidate switch names in documentation Use shorter name for the Hyper-V vSwitch for simplicity of typing it later on. Signed-off-by: Alin Gabriel Serdean <[email protected]> --- Documentation/intro/install/windows.rst | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Documentation/intro/install/windows.rst b/Documentation/intro/install/windows.rst index ece207d..2341b5c 100644 --- a/Documentation/intro/install/windows.rst +++ b/Documentation/intro/install/windows.rst @@ -274,12 +274,12 @@ Enforcement' during boot. The following commands can be used: In the Virtual Switch Manager configuration you can enable the Open vSwitch Extension on an existing switch or create a new switch. -The command to create a new switch named 'OVS-Extended-Switch' using a physical -NIC named 'Ethernet0' is: +The command to create a new switch named 'external' using a physical NIC named +'Ethernet0' is: .. code-block:: ps1con - PS > New-VMSwitch "OVS-Extended-Switch" -NetAdapterName "Ethernet0" ` + PS > New-VMSwitch external -NetAdapterName "Ethernet0" ` -AllowManagementOS $false [SR]: The commit msgh does not mention anything about the "AllowManagementOS" flag being added. What's the reason for this? .. note:: @@ -293,7 +293,7 @@ An alternative way to do the same is to run the following command: .. code-block:: ps1con - PS > Enable-VMSwitchExtension "Open vSwitch Extension" OVS-Extended-Switch + PS > Enable-VMSwitchExtension "Open vSwitch Extension" external .. note:: -- 2.10.2.windows.1 _______________________________________________ dev mailing list [email protected] https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.openvswitch.org_mailman_listinfo_ovs-2Ddev&d=DwICAg&c=uilaK90D4TOVoH58JNXRgQ&r=6OuVHk-mnufSWzkKa74UkQ&m=ANt1MyWGWPCfbl8o7d8EK5wC138sS4Uuzm8XX4IsouA&s=WtqG4fs_RRxuNxJrrZZ7cK19KcdlqwhuzYpesaRapeE&e= _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
