>From net-next commit 87e159c59d9f325d571689d4027115617adb32e6.
Add a break statement to prevent fall-through from
OVS_KEY_ATTR_ETHERNET to OVS_KEY_ATTR_TUNNEL. Without the break
actions setting ethernet addresses fail to validate with log messages
complaining about invalid tunnel attributes.
Fixes: 0a6410fbde ("openvswitch: netlink: support L3 packets")
Signed-off-by: Jarno Rajahalme <[email protected]>
Acked-by: Pravin B Shelar <[email protected]>
Acked-by: Jiri Benc <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
Signed-off-by: Yi Yang <[email protected]>
---
datapath/flow_netlink.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/datapath/flow_netlink.c b/datapath/flow_netlink.c
index 6f6eb02..e455938 100644
--- a/datapath/flow_netlink.c
+++ b/datapath/flow_netlink.c
@@ -2192,6 +2192,7 @@ static int validate_set(const struct nlattr *a,
case OVS_KEY_ATTR_ETHERNET:
if (mac_proto != MAC_PROTO_ETHERNET)
return -EINVAL;
+ break;
case OVS_KEY_ATTR_TUNNEL:
#ifndef USE_UPSTREAM_TUNNEL
--
2.1.0
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
