On 17 February 2017 at 17:47, Yi-Hung Wei <[email protected]> wrote:
> Add a build check that public openvswitch header file should not include
> internal library.
>
> Suggested-by: Joe Stringer <[email protected]>
> Suggested-by: Daniele Di Proietto <[email protected]>
> Signed-off-by: Yi-Hung Wei <[email protected]>
> ---
With the minor caveat below addressed, I applied this to master. Thanks!
I had to apply the following incremental to get my out-of-tree build
to complain correctly:
diff --git a/Makefile.am b/Makefile.am
index 7126ebe55b21..7ff66fe15086 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -230,7 +230,7 @@ config-h-check:
echo "every C source file must #include <config.h>."; \
exit 1; \
fi
- if grep '#include' include/openvswitch/*.h | \
+ if grep '#include' $(srcdir)/include/openvswitch/*.h | \
grep -vE '(<.*>)|("openvswitch)|("openflow)'; \
then \
echo "See above for list of violations of the rule that"; \
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
