> > Signed-off-by: Lorand Jakab <[email protected]> > > Signed-off-by: Simon Horman <[email protected]> > > Signed-off-by: Jiri Benc <[email protected]> > > Signed-off-by: Yi Yang <[email protected]> > > Signed-off-by: Jean Tourrilhes <[email protected]> > > Signed-off-by: Jan Scheurich <[email protected]> > > Co-authored-by: Zoltan Balogh <[email protected]> > > This sign-off chain is baffling. Please explain it.
Support for L3 tunneling has been dragging along for several years. We are just the last ones in a long chain of authors who have submitted earlier versions of patches for this. We thought it was appropriate to keep the earlier Signed-off-by tags to reflect that. If there is a better way to express this, please let us know. > Clang reports: > > ../lib/packets.c:260:22: error: cast from 'char *' to 'ovs_be16 *' (aka > 'unsigned short *') increases required alignment from 1 to 2 [- > Werror,-Wcast-align] > ../lib/packets.c:263:22: error: cast from 'char *' to 'ovs_be16 *' (aka > 'unsigned short *') increases required alignment from 1 to 2 [- > Werror,-Wcast-align] I think these warnings are artifacts caused by the fact that char* does not express the actual alignment of the l2.5 or l3 headers. The packet data is word-aligned and the Ethernet header occupies 14 bytes. Any number of potentially present VLAN tags cannot change that. Any suggestion how to fix this? Thanks , Jan _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
