Unfortunately preconv does not exist in the standard mingw/msys implementation, unless it is downloaded separately(http://embedeo.org/ws/doc/man_windows/).
This will break our existing build CI: https://ci.appveyor.com/project/blp/ovs/build/1.0.2837#L2594 . Thanks, Alin. > -----Original Message----- > From: [email protected] [mailto:ovs-dev- > [email protected]] On Behalf Of Ben Pfaff > Sent: Wednesday, March 8, 2017 11:26 PM > To: Justin Pettit <[email protected]> > Cc: [email protected] > Subject: Re: [ovs-dev] [PATCH] ovs-fields.7: Use a more general approach to > groff encodings. > > On Wed, Mar 08, 2017 at 01:09:00PM -0800, Justin Pettit wrote: > > > > > On Jan 26, 2017, at 10:26 AM, Ben Pfaff <[email protected]> wrote: > > > > > > It turns out that, since groff 1.20 around 2009, groff comes with a > > > preprocessor named "preconv" that can fix encoding issues. Use it > > > instead of the existing hack. > > > > Geez, you didn't know that? Where've you been? > > Apparently, not studying groff. > > > > --- a/lib/automake.mk > > > +++ b/lib/automake.mk > > > @@ -1,4 +1,4 @@ > > > -# Copyright (C) 2009, 2010, 2011, 2012, 2013, 2014, 2015, 2016 Nicira, > > > Inc. > > > +# Copyright (C) 2009, 2010, 2011, 2012, 2013, 2014, 2015, 2016, 2017 > Nicira, Inc. > > > # > > > # Copying and distribution of this file, with or without > > > modification, # are permitted in any medium without royalty provided > > > the copyright @@ -543,6 +543,6 @@ lib/ovs-fields.7: $(srcdir)/build- > aux/extract-ofp-fields include/openvswitch/met > > > $(AM_V_GEN)PYTHONIOENCODING=utf8 $(run_python) $< \ > > > --ovs-version=$(VERSION) ovs-fields \ > > > $(srcdir)/include/openvswitch/meta-flow.h \ > > > - $(srcdir)/lib/meta-flow.xml > [email protected] > > > + $(srcdir)/lib/meta-flow.xml | preconv -e utf-8 > [email protected] > > > > I prefer the forthcoming "precog" preprocessor that doesn't even need > > any arguments, but this will do for now. > > nroff will be the first text processor up against the wall when the text > processing revolution comes. (Never forget, all text processors support > bullets.) > > Applied to master, thanks. > _______________________________________________ > dev mailing list > [email protected] > https://mail.openvswitch.org/mailman/listinfo/ovs-dev _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
