On 10 March 2017 at 11:34, Joe Stringer <[email protected]> wrote: > On 9 March 2017 at 10:22, Yi-Hung Wei <[email protected]> wrote: >> On Wed, Mar 8, 2017 at 11:40 AM, Joe Stringer <[email protected]> wrote: > diff --git a/lib/meta-flow.c b/lib/meta-flow.c > index e844008f6294..bef5aad768a3 100644 > --- a/lib/meta-flow.c > +++ b/lib/meta-flow.c > @@ -2836,9 +2836,13 @@ mf_vl_mff_ref_cnt_mod(const struct vl_mff_map > *map, uint64_t tlv_bitmap, > vmf = mf_get_vl_mff__(i + MFF_TUN_METADATA0, map); > if (vmf) { > if (ref) { > - ovs_refcount_ref(&vmf->ref_cnt); > + if (ovs_refcount_ref(&vmf->ref_cnt) == 0) { > + VLOG_WARN("Taking reference on freed VMF %d", i); > + }
Turns out that ovs_refcount_ref() already asserts this ;-) _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
