On Fri, Mar 17, 2017 at 11:38:35AM -0700, Joe Stringer wrote: > It's slightly more cognitive load to read an inverse condition and then > invert it again to understand the 'else' condition. > > Signed-off-by: Joe Stringer <[email protected]>
It's also somewhat odd to handle the error condition before the common case--I think that CodingStyle actually has something to say about this--so maybe we should instead flip 'limited' to become its inverse 'below_limit' (and then rename the parameter to below_limitp or below_limit_). But if you like this better it's not a big deal to me, so: Acked-by: Ben Pfaff <[email protected]> _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
