>-----Original Message----- >From: Aaron Conole [mailto:acon...@redhat.com] >Sent: Monday, April 3, 2017 1:58 AM >To: Bodireddy, Bhanuprakash <bhanuprakash.bodire...@intel.com> >Cc: d...@openvswitch.org >Subject: Re: [ovs-dev] [PATCH 1/7] dpdk: Add helper functions for DPDK >keepalive. > >Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> writes: > >> Introduce helper functions in 'dpdk' module that are needed for >> keepalive functionality. Also add dummy functions in 'dpdk-stub' >> module that are needed when DPDK is not available. >> >> Signed-off-by: Bhanuprakash Bodireddy >> <bhanuprakash.bodire...@intel.com> >> --- > >I think it's better to add helpers at the time they are first called. >That means that there's no dead code at any point in the build, and it >becomes obvious why the function is added.
Completely agree. I split my earlier RFC patch in to smaller patches and rebased them with master and later realized they were out of order. I will handle this appropriately in next version. -Bhanuprakash. _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
