Hi, > Nothing else in the Idl class is touching the reconnect object > directly, which makes me wonder if this should also be a method on the > session, or perhaps an option to Session.open(). > > I also wonder if it'd be better as an optional argument to the > constructor so that we can pass in the desired value before the > connection is opened and is used from the beginning. The separate > method is tempting as far as writing code that can deal with versions > of this library that may or may not have support for the official way > of setting this, but it still feels like the "right" way is to be able > to set the value before the connection is even opened. What do you > think? > > I feel like I'm nit picking this, sorry for that.
Not at all! That's some really useful feedback. Sure, let's set the probe_interval value before we connect, it makes total sense. Also, I noted that there's some logic checking whether to enable/disable proving when the connection is being opened [0] which we should consider. I will push a new patch soon. Thanks for the inputs! [0] https://github.com/openvswitch/ovs/blob/1b996ac917392b66cff5b7bb660c94ceb897ba57/python/ovs/jsonrpc.py#L398-L399 Cheers, Lucas _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
