On Fri, Apr 07, 2017 at 06:21:18PM -0400, Lance Richardson wrote: > > From: "Ben Pfaff" <[email protected]> > > To: "Lance Richardson" <[email protected]> > > Cc: [email protected], [email protected] > > Sent: Friday, 7 April, 2017 6:13:44 PM > > Subject: Re: [PATCH] m4: fix use of log fd vs. file in "configure" > > > > On Fri, Apr 07, 2017 at 05:05:06PM -0400, Lance Richardson wrote: > > > Recent Travis builds are failing when making the distcleancheck > > > target with: > > > ERROR: files left in build directory after distclean: > > > ./5 > > > > > > Fix by treating log fd as a file descriptor instead of a file. > > > > > > Fixes: commit 7777d53d2f4b ("m4: Add hard requirements for python > > > in "configure") > > > > > > Signed-off-by: Lance Richardson <[email protected]> > > > > Oops. My mistake. Thank you for the fix! Applied to master. > > > > BTW, I noticed some builds are failing with: > > checking for library containing get_mempolicy... no > configure: error: unable to find libnuma, install the dependency package > > > The obvious thing to do would seem to be adding libnuma-dev to .travis.yml, > but this commit makes me wonder if something else has changed: > > commit 435aadddc8167d6b5551c2884510776bca574ea6 > Author: Ciara Loftus <[email protected]> > Date: Thu Aug 4 11:44:40 2016 +0100 > > netdev-dpdk: Make libnuma dependencies optional > > Prior to this patch, OVS with DPDK required the libnuma packages to > build. This patch removes this dependency, making it only a requirement > when the CONFIG_RTE_LIBRTE_VHOST_NUMA option is detected as enabled in > the DPDK build. > > Signed-off-by: Ciara Loftus <[email protected]> > Acked-by: Daniele Di Proietto <[email protected]>
At first glance, the code in acinclude.m4 seems to properly implement this, where it checks for RTE_LIBRTE_VHOST_NUMA and if present adds a requirement for libnuma. Maybe something else changed, so my first thought would be to add libnuma-dev to .travis.yml (as you suggest). _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
