On 13/04/2017 12:24, "Johannes Berg" <johan...@sipsolutions.net> wrote:
> On Thu, 2017-04-13 at 16:05 +0200, Nicolas Dichtel wrote: > > > Sure. It was just to mention that attribute 0 exists somewhere. > > The other 0 attribute is OVS_TUNNEL_KEY_ATTR_ID. > > That looks like some really awkward hand-grown parsing - with all these > "struct ovs_len_tbl" looking almost like a policy, but not using that > code? > > Seems like something somebody should take a hard look at and see if it > can't use more standard infrastructure. > I think that OVS was doing some more elaborate validation than most users, so over time we picked up a bunch of extra parsing code that layers on top of nla_parse(). I took a look at trying to broaden this and make it useful to other users a while ago, but when I posted there wasn't much interest from others on it so I just moved on. Maybe it's about time to pick that back up. _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
