On Fri, Apr 14, 2017 at 09:05:41AM -0700, Greg Rose wrote:
> On Thu, 2017-04-13 at 10:47 -0700, Ben Pfaff wrote:
> > Commit 618a5b45ae8b ("rhel: Avoid logrotate error if /var/run/openvswitch
> > does not exist") updated the RHEL logrotate configuration.  This commit
> > makes similar changes for Debian, by synchronizing with the RHEL version.
> > 
> > In particular:
> > 
> >     - Indent to match logrotate.conf(5) examples.
> > 
> >     - Use "sharedscripts" flag, because the postrotate script only needs to
> >       run once regardless of the number of rotations.
> > 
> >     - Drop "delaycompress", because the postrotate script does make daemons
> >       reopen their log files.
> > 
> >     - Ignore errors calling vlog/reopen.
> > 
> > Also make similar changes to the xenserver logrotate script.  I really
> > don't know if anyone uses the xenserver packaging anymore though.
> 
> Hi Ben,
> 
> I'm actually trying to build the latest upstream OVS from github on a
> Xen Server 7.1 system.  I have followed the instructions as well as I
> could and everything seems to build pretty well in the Xen Server 7.1
> DDK VM until finally it fails with the following error output:
> 
> Checking for unpackaged
> file(s): /usr/lib/rpm/check-files 
> /prj/gvrose/rpmbuild/BUILDROOT/openvswitch-2.7.90-1.x86_64
> error: Installed (but unpackaged) file(s) found:
>    /usr/bin/ovs-tcpdump
>    /usr/share/man/man7/ovs-fields.7.gz
>    /usr/share/man/man8/ovs-tcpdump.8.gz
>    /usr/share/openvswitch/scripts/ovndb-servers.ocf
> 
> 
> RPM build errors:
>     Installed (but unpackaged) file(s) found:
>    /usr/bin/ovs-tcpdump
>    /usr/share/man/man7/ovs-fields.7.gz
>    /usr/share/man/man8/ovs-tcpdump.8.gz
>    /usr/share/openvswitch/scripts/ovndb-servers.ocf
> 
> I suppose there is some file list that needs updating?

Yes, please look in xenserver/openvswitch-xen.spec.in.

However, this may be a good sign that no one cares about XenServer,
since Open vSwitch 2.6.0, released in September last year, also installs
at least /usr/bin/ovs-tcpdump, and no one has complained.  Perhaps we
should just delete the packaging, instead, and save ourselves some
trouble.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to